Handle insert/update/delete responses in query_many #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
approved these changes
Aug 20, 2024
Comment on lines
-278
to
+279
| defp result( | ||
| {:ok, | ||
| ok_packet( | ||
| last_insert_id: last_insert_id, | ||
| affected_rows: affected_rows, | ||
| status_flags: status_flags, | ||
| num_warnings: num_warnings | ||
| )}, | ||
| query, | ||
| state | ||
| ) do | ||
| result = %Result{ | ||
| connection_id: state.client.connection_id, | ||
| last_insert_id: last_insert_id, | ||
| num_rows: affected_rows, | ||
| num_warnings: num_warnings | ||
| } | ||
|
|
||
| {:ok, query, result, put_status(state, status_flags)} | ||
| defp result({:ok, ok_packet(status_flags: status_flags) = result}, query, state) do | ||
| {:ok, query, format_result(result, state), put_status(state, status_flags)} |
Comment on lines
+290
to
+291
| # Keep status flags from the last query. The results are given | ||
| # to this function in reverse order, so it is the first one. |
lib/myxql/connection.ex
Outdated
| ), | ||
| state | ||
| ) do | ||
| columns = Enum.map(column_defs, &elem(&1, 1)) |
There was a problem hiding this comment.
Suggested change
| columns = Enum.map(column_defs, &elem(&1, 1)) | |
| columns = Enum.map(column_defs, &column_def(&1, :name)) |
test/myxql_test.exs
Outdated
Comment on lines
212
to
213
| assert {:ok, [%MyXQL.Result{num_rows: 1}]} = | ||
| MyXQL.query_many(c.conn, "INSERT INTO integers VALUES (1);", [], query_type: :text) |
There was a problem hiding this comment.
could you assert on columns: too?
ckoch-cars
pushed a commit
to carsdotcom/myxql
that referenced
this pull request
Oct 10, 2024
update script for newer docker formats update workflow update grid for CI tests
ckoch-cars
pushed a commit
to carsdotcom/myxql
that referenced
this pull request
Oct 10, 2024
update script for newer docker formats update workflow update grid for CI tests
ckoch-cars
pushed a commit
to carsdotcom/myxql
that referenced
this pull request
Oct 10, 2024
update script for newer docker formats update workflow update grid for CI tests
iacutone
pushed a commit
to carsdotcom/myxql
that referenced
this pull request
Oct 22, 2024
update script for newer docker formats update workflow update grid for CI tests
ckoch-cars
added a commit
to carsdotcom/myxql
that referenced
this pull request
Oct 22, 2024
* Permit geo ~> 4.0 (elixir-ecto#196) * Handle insert/update/delete responses in query_many (elixir-ecto#194) update script for newer docker formats update workflow update grid for CI tests * revert docker-compose to main remove comment update DB lang pairs revert some changes from master * Fix typespec * Revert ci.yml change --------- Co-authored-by: Greg Rychlewski <[email protected]> Co-authored-by: iacutone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #193
There are still a lot of other weird situations where query_many will break, see here. But this will fix the use case in the issue. If there is interest, we can continue fixing query_many completely but I need some time to play with the old PR to understand what was happening.