Make Repo.reload respect source (#4510)

elixir-ecto · Sep 26, 2024 · e3f038f · e3f038f
1 parent b4ad5fc
commit e3f038f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/ecto/repo/queryable.ex b/lib/ecto/repo/queryable.ex
@@ -491,12 +491,12 @@ defmodule Ecto.Repo.Queryable do
     assert_structs!(structs)
 
     schema = head.__struct__
-    prefix = head.__meta__.prefix
+    %{prefix: prefix, source: source} = head.__meta__
 
     case schema.__schema__(:primary_key) do
       [pk] ->
         keys = Enum.map(structs, &get_pk!(&1, pk))
-        query = Query.from(x in schema, where: field(x, ^pk) in ^keys)
+        query = Query.from(x in {source, schema}, where: field(x, ^pk) in ^keys)
         %{query | prefix: prefix}
 
       pks ->

diff --git a/test/ecto/repo_test.exs b/test/ecto/repo_test.exs
@@ -334,6 +334,12 @@ defmodule Ecto.RepoTest do
       TestRepo.reload(struct_with_prefix)
       assert_received {:all, %{prefix: %{key: :another}}}
     end
+
+    test "respects source" do
+      struct_with_custom_source = put_meta(%MySchema{id: 2}, source: "custom_schema")
+      TestRepo.reload(struct_with_custom_source)
+      assert_received {:all, %{from: %{source: {"custom_schema", MySchema}}}}
+    end
   end
 
   defmodule DefaultOptionRepo do