Fix inspecting dynamic/2 with interpolated named bindings (#4541)

elixir-ecto · Nov 3, 2024 · d47bc2c · d47bc2c
1 parent 98ba6fe
commit d47bc2c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/ecto/query/inspect.ex b/lib/ecto/query/inspect.ex
@@ -5,6 +5,14 @@ alias Ecto.Query.{DynamicExpr, JoinExpr, QueryExpr, WithExpr, LimitExpr}
 
 defimpl Inspect, for: Ecto.Query.DynamicExpr do
   def inspect(%DynamicExpr{binding: binding} = dynamic, opts) do
+    binding =
+      Enum.map(binding, fn
+        {{:^, _, [as]}, bind} when is_atom(as) -> {as, bind}
+        other -> other
+      end)
+
+    dynamic = %{dynamic | binding: binding}
+
     joins =
       binding
       |> Enum.drop(1)

diff --git a/test/ecto/query/inspect_test.exs b/test/ecto/query/inspect_test.exs
@@ -41,6 +41,9 @@ defmodule Ecto.Query.InspectTest do
     assert inspect(dynamic([comments: c], c.bar == ^1)) ==
              "dynamic([comments: c], c.bar == ^1)"
 
+    assert inspect(dynamic([{^:comments, c}], c.bar == ^1)) ==
+             "dynamic([comments: c], c.bar == ^1)"
+
     dynamic = dynamic([p], p.bar == ^1)
 
     assert inspect(dynamic([p], ^dynamic and p.foo == ^0)) ==