refactor: update code for type checks #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaeAeich
commented
Feb 10, 2024
JaeAeich
commented
Feb 10, 2024
uniqueg
reviewed
Mar 18, 2024
|
I'm not really sure about, task_id = logs[0].metadata["remote_task_id"]so ignored it atm, the error it gives is pro_tes/ga4gh/tes/task_runs.py:391: error: Value of type "Metadata" is not indexable [index]which makes sense looking at the class definition of it, maybe I'm missing something 🤷♂️ ! PS: This is solved. |
I guess this is where Will leave this as is, with the |
uniqueg
changed the title
uniqueg
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please create an issue before filing a pull request! Changes need to be discussed before proceeding. Please read the contribution guidelines.
Details
This PR aims to add type-checking, partly addressing #116