Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentence_capitalization should only be applied to actual sentences #228

Open
chrisgrieser opened this issue Oct 16, 2024 · 3 comments
Open

Comments

@chrisgrieser
Copy link

Right now, sentence_capitalization is applied to all comments, regardless whether that comment is actually a sentence, a word, or commented out code. This leads to a lot of false positives, making sentence_capitalization for me pretty much unusable outside of markdown files:

Pasted image 2024-10-16 at 17 09 13@2x

@grantlemons
Copy link
Collaborator

I agree that it creates more false-positives that it's worth right now. I'm of the opinion it should not be enabled by default until the implementation is more mature.

@elijah-potter thoughts?

@elijah-potter
Copy link
Owner

I'm so sorry I haven't been able to get to this until now. I've been swamped. You're absolutely right that it needs work. Rather than simply disable it by default, I'd rather work with you, @chrisgrieser, to get it to a place we can proud of.

I've made some changes that will hopefully improve it.

Are you in a position where you frequently Harper from source? If not, it's high time we ran a release, so let me know if that needs to happen for you to test the changes.

@chrisgrieser
Copy link
Author

Are you in a position where you frequently Harper from source?

I do not, so yeah a release would be be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants