You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, sentence_capitalization is applied to all comments, regardless whether that comment is actually a sentence, a word, or commented out code. This leads to a lot of false positives, making sentence_capitalization for me pretty much unusable outside of markdown files:
The text was updated successfully, but these errors were encountered:
I agree that it creates more false-positives that it's worth right now. I'm of the opinion it should not be enabled by default until the implementation is more mature.
I'm so sorry I haven't been able to get to this until now. I've been swamped. You're absolutely right that it needs work. Rather than simply disable it by default, I'd rather work with you, @chrisgrieser, to get it to a place we can proud of.
I've made some changes that will hopefully improve it.
Are you in a position where you frequently Harper from source? If not, it's high time we ran a release, so let me know if that needs to happen for you to test the changes.
Right now,
sentence_capitalization
is applied to all comments, regardless whether that comment is actually a sentence, a word, or commented out code. This leads to a lot of false positives, makingsentence_capitalization
for me pretty much unusable outside of markdown files:The text was updated successfully, but these errors were encountered: