Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a package.json file #46

Closed
wants to merge 1 commit into from
Closed

Conversation

sroucheray
Copy link
Contributor

package.json file will allow classList.js repo to be installed via NPM
(even if it is not published on the NPM registry - via its GitHub URL).
This does not change any aspect of classList.js but will just ease its
usage.

package.json file will allow classList.js repo to be installed via NPM
(even if it is not published on the NPM registry - via its GitHub URL).
This does not change any aspect of classList.js but will just ease its
usage.
@sroucheray sroucheray mentioned this pull request Jan 13, 2016
@tomByrer
Copy link

I wonder if NPM will have issues with classList mixedCase file name; I know Bower had in the past?

@sroucheray
Copy link
Contributor Author

If you meant package name, yes it has.

New packages must not have uppercase letters in the name.

https://docs.npmjs.com/files/package.json

@phueper
Copy link

phueper commented Feb 25, 2016

👍

@W0nderMuffin
Copy link
Contributor

And please consider to change the package name mdn-classlist.js ;)

@le717
Copy link

le717 commented Feb 28, 2016

Yes, could you please see about getting this PR merged? I keep wanting to install this pollyfill from npm but forget it does not have a package file. :)

@eligrey
Copy link
Owner

eligrey commented Feb 28, 2016

The current version of classList.js is not 1.0.0, it's 1.1.20150312.

@le717 @phueper @sroucheray @tomByrer: I don't use this repo for package manager syndication. Package maintainers (that can be you) can maintain packages for their preferred package managers. I only use GitHub for git. Btw, git has a built-in dependency tool called submodules. You could try using that instead if you are unwilling to maintain a few lines of metadata for whatever your preferred package manager is.

Here's one entry already on npm.

@W0nderMuffin Why? I'm not a Mozilla employee, and I was not hired to write this for MDN.

@eligrey eligrey closed this Feb 28, 2016
@le717
Copy link

le717 commented Feb 28, 2016

My desire was to simply use npm to install this straight from GitHub as part of my dependencies:

"classlist": "github:eligrey/classList.js"

I wasn't really asking for it to be on npm, just be able to install it from here. I do know about submodules but I did not want to use them in my (admittedly simple) project. As for the version on npm, last I checked I think it was out of date (that may have changed now).

I can understand your decision for not wanting to add such a file, but considering how often your pollyfill is referenced and used, such a file just in the repo, doesn't matter if it's on npm or not, could be a very advantageous thing for many developers.

@eligrey
Copy link
Owner

eligrey commented Feb 28, 2016

Alright, since it's popular and won't be a big deal, you guys can add this file, but please submit a pullreq with the correct version (1.1.20150312) and license (public domain).

@W0nderMuffin
Copy link
Contributor

@sroucheray now you can merge and do a new pullreq ;)

@sroucheray
Copy link
Contributor Author

I merged and created a new PR #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants