Abstract title handling #532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fred-atherden thanks for this. PR is valuable would be great to create a ticket too and link to this PR in ticket so that it is on @QueenKraken's radar. |
|
Thanks @nlisgo. @QueenKraken we've recently published some RPs affected by this (https://elifesciences.org/reviewed-preprints/87039, https://elifesciences.org/reviewed-preprints/86507, https://elifesciences.org/reviewed-preprints/86700), so would be good to get this in the backlog and picked up at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some preprints have an alternative title for the abstract. In these cases I suggest we retain fidelity with the original.
This issue wasn't apparent until this change in encoda - https://github.com/elifesciences/enhanced-preprints-issues/issues/505 - which introduced these extra headings into the json.
The abstract component currently adds an h1
Abstractto everything. BecausecontentToJsxwill still iterate over all the content provided, both titles are rendered on EPP with the same level which looks a little odd. e.g.:https://prod--epp.elifesciences.org/preview/10.1101/2020.01.28.922773
This is an attempt to ensure that the default
Abstractheading is only included when there's not one provided in the original data. Same abstract locally with this change: