Reference year preserve suffix #2195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlisgo
reviewed
Oct 25, 2024
| @@ -107,10 +107,16 @@ describe('Reference', () => { | |||
| expect(screen.getByText('NoGiven').textContent).toStrictEqual('NoGiven'); | |||
| }); | |||
|
|
|||
| it('should render without a publishedYear', () => { | |||
| it.failing('should render without a publishedYear', () => { | |||
There was a problem hiding this comment.
This is failing because meta.yearPublished is set but wasn't being shown prior to your adjustment to reference.tsx
There was a problem hiding this comment.
We should remove it from the mock so that we can support the existence of this test: https://github.com/elifesciences/enhanced-preprints-client/blob/master/src/utils/mocks/references.ts#L116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.