Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow-type #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add flow-type #6

wants to merge 1 commit into from

Conversation

steida
Copy link

@steida steida commented Feb 25, 2017

  • Nice code, no warnings at all, except one.
  • Added some types.
  • Don’t be surprised code is slightly reformatted. I am using awesome
    jlongster/prettier, everybody should use it.
  • flow-type helps a lot, code navigation eases lib exploration

- Nice code, no warnings at all, except one.
- Added some types.
- Don’t be surprised code is slightly reformatted. I am using awesome
jlongster/prettier, everybody should use it.
- flow-type helps a lot, code navigation eases lib exploration
@elierotenberg
Copy link
Owner

Thanks for your PR, let me think about prettier for a little bit before merging it :)

@steida
Copy link
Author

steida commented Feb 25, 2017

Try it on some project. You will not regret. https://github.com/jlongster/prettier-atom

@elierotenberg
Copy link
Owner

Hello, sorry for the long delay. e1342fc added prettier.
Would you like to help me rebasing your PR onto master, now that some other changes have been merged and the code structure has evolved a bit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants