fix(firestore): Allow using != with nil (googleapis#11112)

eliben · Nov 11, 2024 · 5b59819 · 5b59819
1 parent f072178
commit 5b59819
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/firestore/integration_test.go b/firestore/integration_test.go
@@ -1394,6 +1394,7 @@ func TestIntegration_QueryUnary(t *testing.T) {
 		want map[string]interface{}
 	}{
 		{base.Where("q", "==", nil), wantNull},
+		{base.Where("q", "!=", nil), wantNull},
 		{base.Where("q", "==", math.NaN()), wantNaN},
 	} {
 		got, err := test.q.Documents(ctx).GetAll()

diff --git a/firestore/query.go b/firestore/query.go
@@ -1114,7 +1114,7 @@ func (f PropertyPathFilter) toProto() (*pb.StructuredQuery_Filter, error) {
 		return nil, err
 	}
 	if uop, ok := unaryOpFor(f.Value); ok {
-		if f.Operator != "==" {
+		if f.Operator != "==" && !(f.Operator == "!=" && f.Value == nil) {
 			return nil, fmt.Errorf("firestore: must use '==' when comparing %v", f.Value)
 		}
 		ref, err := fref(f.Path)