Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Switch to arm-compatible Selenium image #39

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

eliashaeussler
Copy link
Owner

@eliashaeussler eliashaeussler commented Mar 16, 2022

This PR exchanges the Selenium image used for acceptance tests.

-selenium/standalone-chrome-debug:3.13.0-argon
+seleniarm/standalone-chromium:4.1.2-20220227

The new image supports ARM as well, adding support for Apple M1 computers.

Related issue: SeleniumHQ/docker-selenium/issues/1076

@eliashaeussler eliashaeussler added the bug Something isn't working label Mar 16, 2022
@eliashaeussler eliashaeussler self-assigned this Mar 16, 2022
@codeclimate
Copy link

codeclimate bot commented Mar 16, 2022

Code Climate has analyzed commit f4146e7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.5% (0.0% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #39 (f4146e7) into develop (3f08cb4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #39   +/-   ##
==========================================
  Coverage      93.52%   93.52%           
  Complexity       267      267           
==========================================
  Files             30       30           
  Lines            741      741           
==========================================
  Hits             693      693           
  Misses            48       48           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f08cb4...f4146e7. Read the comment docs.

@eliashaeussler eliashaeussler merged commit 430b431 into develop Mar 16, 2022
@eliashaeussler eliashaeussler deleted the bugfix/selenium-arm-support branch March 16, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant