-
-
Notifications
You must be signed in to change notification settings - Fork 333
Conversation
We have been trying to upgrade during this week with @elgalu but the tests are not passing, we are also upgrading Geckodriver and Firefox... Since it is strongly recommended to use Geckodriver 0.16 with Selenium 3.4.0 |
yup heard about the firefox crash with old versions @diemol Will look into it further. |
Hi, thanks for contributing @SrinivasanTarget ! As Diego mentioned we haven't been able to upgrade because the selenium python tests are failing, even when upgrading the requirements.txt to use selenium 3.4.0 python bindings, it just halts at |
Yes @elgalu Unfortunately not enough logs to debug. Is it something to do with python version we use? i didn't give a try in python 3+. |
I'm using python 3.5.2, I will try 3.6.1 later on but I think the problem is more python bindings related or perhaps an API change, this is the current python test that's failing: |
Yes I did had a look at the test here https://github.com/elgalu/docker-selenium/blob/master/test/python_test.py#L52 but was not able to figure out :( |
So you can reproduce the error locally? |
@elgalu Nope i havent tried it locally.. will try it |
Maybe it gets fixed with the new version they released today 3.4.2 see https://pypi.python.org/pypi/selenium |
stills fails |
Selenium 3.5.0 was released but still has the same issues. |
I tried latest Selenium 3.5.2 and it doesn't seem to like some of our custom grid capabilities, as can be seen in this logs:
|
Finally managed to upgrade to 3.4.0, see branch: https://github.com/elgalu/docker-selenium/tree/3.4.0 and tests now passing Users can pull 3.4.0 image: However latest wasn't updated as we want to move latest only for 3.5.3 which has fixed: SeleniumHQ/selenium#3808 (comment) |
No description provided.