Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credential): audit changes credential #250

Merged
merged 12 commits into from
Sep 30, 2022

Conversation

dixitaniket
Copy link
Contributor

No description provided.

@dixitaniket dixitaniket marked this pull request as ready for review September 19, 2022 16:54
@dixitaniket dixitaniket requested a review from a team as a code owner September 19, 2022 16:54
Copy link
Contributor

@noandrea noandrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! let's take care of those 2 TODO then let's smash the big green button !

x/credential/credential_test.go Outdated Show resolved Hide resolved
x/credential/keeper/genesis.go Outdated Show resolved Hide resolved
Copy link
Contributor

@noandrea noandrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noandrea noandrea merged commit fe9a9ee into release/v2.0.0 Sep 30, 2022
@noandrea noandrea deleted the fix/audit-changes-credential branch September 30, 2022 09:15
noandrea added a commit that referenced this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants