Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center icon list icons #8219

Closed
2 tasks done
theDanielJLewis opened this issue May 28, 2019 · 3 comments
Closed
2 tasks done

Center icon list icons #8219

theDanielJLewis opened this issue May 28, 2019 · 3 comments
Labels
status/merged Indicates when a Pull Request has been merged to a Release.
Milestone

Comments

@theDanielJLewis
Copy link

Prerequisites

  • I have searched for similar features requests in both open and closed tickets and cannot find a duplicate.
  • The feature is still missing in the latest stable version of Elementor ( Elementor Pro. )

What problem is your feature request going to solve? Please describe.

Wide and narrow icons in an icon list look weird due to default left alignment.

Describe the solution you'd like
Either default .elementor-icon-list-icon to text-align: center;, or else give an icon-alignment option.

Additional context
Current view with default left alignment. Notice the weird gaps between the icons and the text.
Left

Custom-CSS view with center alignment.
Center

@shilo-ey shilo-ey added the status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged. label May 30, 2019
@shilo-ey
Copy link
Contributor

Hi @theDanielJLewis

Thanks for your feedback.

We will consider adding this option in the next major release.

Thanks

@shilo-ey shilo-ey added this to the 2.6.0 milestone May 30, 2019
@Helmi
Copy link

Helmi commented May 30, 2019

@shilo-ey out of curiosity: By putting it on a milestone are you still considering a change or is this means as a clear indication as what will come in this release? Just curious as there's some stuff on the 2.6.0 milestone that I'm waiting for quite a long time. It's crucial for me to know if this is coming or only be considered and possibly thrown away again.

@shilo-ey
Copy link
Contributor

shilo-ey commented Jun 3, 2019

A pull request has been submitted to our review team.

If they will find it Ok, it will be in v2.6.0

Thanks

arielk added a commit that referenced this issue Jun 10, 2019
Tweak: Added icon alignment options to icon list closes #8219
@arielk arielk added status/merged Indicates when a Pull Request has been merged to a Release. and removed status/has-pr Indicates that an Issue, or Discussion has a companion Pull Request awaiting to be merged. labels Jun 11, 2019
@KingYes KingYes closed this as completed in 6d6a8f2 Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/merged Indicates when a Pull Request has been merged to a Release.
Projects
None yet
Development

No branches or pull requests

4 participants