Support Buttons 2 #258
Closed
Support Buttons 2 #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've implemented the mentioned solution at elementary/notifications#192 and can confirm it is working now. However I'm not sure whether there might be a better way? For testing I monitored the notifications DBus using |
Merged
|
Closing in favor of an alternative implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently doesn't workbecause it seems emitting signals on a foreign DBus Object (is this correct terminology?) isn't possible (which would make sense). However it was used here before (for the default action) so maybe I missed something?A possible solution would maybe be to implement a DBus method in elementary/notifications that then emits the
ActionInvokedsignal onorg.freedesktop.Notifications.