Fix clear and reset actions when ongoing foreground process #823
+69
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
force-pushed
the
jeremypw/fix-actions-with-foreground-process
branch
from
477818d to
c177232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #819
Fixes #820
nanoBecause we cannot guarantee the state of the terminal if the foreground process is killed (see #824 ) the clear action is ignored when a foreground process is running. Resetting the terminal is OK as the terminal state is reset to something sensible.
There is little difference between the "Reload" action and the "Reset" action. The former starts a new shell process whereas the latter resets the existing one. Not sure if we need both. Only the latter is shown in the context menu atm.