Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tab to new window created with <Shift><Ctrl>N #816

Merged
merged 8 commits into from
Dec 9, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Dec 6, 2024

Fixes #814

  • New tab added in Application new-window action handler
  • New window follows size of current window
  • New tab follows current working directory of current window

There is scope for improving consistency and DRYing with code handling new windows created by dragging tabs, from the dock and from the commandline but that is left for now.

Code potentially changing the window size by adding a tab was removed as it did not seem appropriate. The window size is already controlled by settings, the user and the window manager.

@jeremypw jeremypw marked this pull request as ready for review December 6, 2024 16:58
@danirabbit
Copy link
Member

Nice fix!

@danirabbit danirabbit enabled auto-merge (squash) December 9, 2024 21:34
@danirabbit danirabbit merged commit c2852a5 into master Dec 9, 2024
3 of 4 checks passed
@danirabbit danirabbit deleted the jeremypw/fix-new-window branch December 9, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New window created with `<Ctrl><Shift>N' has zero tabs and is transparent
2 participants