Drop dead feature that disables unsafe paste warning while Terminal opens #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think now we have the toggle in the App menu to control the unsafe warning we do not need this additional check in the dialog. |
We can now toggle unsafe paste warning from prerferences menu, so this feature that prevents unsafe paste warning from being shown just during the session is useless.
ryonakano
changed the title
|
@jeremypw Thank you for your opinion. I agree with you and perform changes to drop this dead feature. |
jeremypw
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dead feature that disables unsafe paste warning while Terminal opens.
As far as reading the code of UnsafePasteDialog.vala, this dialog shouldn't appear again while the current Terminal window is alive once if the user clicks "Paste Anyway". However, this isn't working at the moment because the clicked event of the "Paste Anyway" button is treated as a response of UnsafePasteDialog and the
on_ignore ()method is not triggered at all.On the other hand, however, I also feels the current "unintentional" behavior that this dialog always appears when pasting administrative commands makes sense too. We can now toggle unsafe paste warning from preferences menu,
so this dead feature is useless. Therefore, I just dropped the dead feature instead of correctly implementing it in favor of current "unintentional" behavior.