-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.flatpakrepo support #92
base: main
Are you sure you want to change the base?
Conversation
} | ||
|
||
public void display_details (string? title) { | ||
primary_label.label = _("Add untrusted software source “%s”".printf (title)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
primary_label.label = _("Add untrusted software source “%s”".printf (title)); | |
primary_label.label = _("Add untrusted software source “%s”?".printf (title)); |
@davidmhewitt I'm a fan of this direction so far. :) I think the error view can probably be shared if that makes sense, but the success view is going to have a different title, body, and actions, so it might make sense to keep it separate. Something like:
|
I'm not sure if this is still being considered, but as it directly effects its app selection this should be an AppCenter dialog instead imo |
@hanaral Sideload handles sideloading things from outside of AppCenter, including Flatpak refs, bundles, and (with this PR) repo files. This is still definitely wanted, but it'll need to be rebased on master as there have been a lot of changes there. |
Fixes #72
Still do to:
It seems like there's already quite a bit of duplicated UI code here, so I don't know if we want to do something more clever. But the success view and error view classes are pretty short and can probably be tweaked slightly to be the success view and error view for both Repos and Refs.