Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.flatpakrepo support #92

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

.flatpakrepo support #92

wants to merge 5 commits into from

Conversation

davidmhewitt
Copy link
Member

Fixes #72

Still do to:

  • Sort out POTFILES after renames and new files
  • Detect if a remote is already added and do something?
  • Show a success view on success
  • Show an error view on error (both error parsing file and adding repo)

It seems like there's already quite a bit of duplicated UI code here, so I don't know if we want to do something more clever. But the success view and error view classes are pretty short and can probably be tweaked slightly to be the success view and error view for both Repos and Refs.

}

public void display_details (string? title) {
primary_label.label = _("Add untrusted software source “%s”".printf (title));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
primary_label.label = _("Add untrusted software source “%s".printf (title));
primary_label.label = _("Add untrusted software source “%s?".printf (title));

@cassidyjames
Copy link
Contributor

@davidmhewitt I'm a fan of this direction so far. :) I think the error view can probably be shared if that makes sense, but the success view is going to have a different title, body, and actions, so it might make sense to keep it separate. Something like:

Added “Flathub” to software sources

Non-curated apps and updates from “Flathub” will now appear in AppCenter.

Close Open AppCenter

@hanaral
Copy link

hanaral commented Apr 27, 2021

I'm not sure if this is still being considered, but as it directly effects its app selection this should be an AppCenter dialog instead imo
Maybe there should be even more distinction between AppCenter and non-AppCenter apps?

@cassidyjames
Copy link
Contributor

@hanaral Sideload handles sideloading things from outside of AppCenter, including Flatpak refs, bundles, and (with this PR) repo files. This is still definitely wanted, but it'll need to be rebased on master as there have been a lot of changes there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle .flatpakrepo files
3 participants