Watch for xdg-desktop-portal starting before binding style scheme #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
approved these changes
Oct 27, 2021
davidmhewitt
added a commit
that referenced
this pull request
Oct 27, 2021
danirabbit
pushed a commit
that referenced
this pull request
Oct 27, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
In theory, this is a case where Granite could (and does eventually) fall back to using AccountsService to get the style preference. But because the unsandboxed portals process can see there's a Settings Portal that it could DBus activate, it tries and blocks everything until it times out.
So instead of trying to initialise the
Granite.Settingsclass right away, lets wait until the Settings Portal is there, so Granite can connect to it instead of trying to DBus activate it while it's already trying to start.