Choose project popover

[jeremypw]

Fixes #991 (partially)
Alternative implementation to #1023, similar to that used for FormatBar.

Open questions, given that the number of open projects is likely to be small compared with number of formats:

• What to do with non-active project folders and documents

A potential future development would be to maintain a list of recent but not loaded projects that could also be displayed in the list.

[jeremypw]

[hanaral]

From the screenshot it's even better than what I was thinking! I think there may be some debate as to whether it should adapt to the number of projects i.e if >8 then make it scrollable otherwise crop the popover to fit the number of entries
I'm in favour of making it adaptable

[jeremypw]

@hanaral Yes, unless/until we display recent but not loaded projects as well as loaded projects the list is unlikely to contain more than 3 projections in my opinion. Trying to work with more than that at once would be unwieldy.

[hanaral]

I do still think it would be useful to have it, in case Code is used by other projects that need their tools to scale.
Apart from that, do you think you could fix the button's UX in this PR too? It just needs to be the same size as the other headerbar button widgets, and use a symbolic bit icon rather than the coloured (although a single colour icon could also work, similarly to the settings popover)

[jeremypw]

We need to raise an issue in the icons project for a symbolic (git) project icon.

I'll fix the button height - I copied the code from the formatbar but I must have missed something.

[jeremypw]

Added margins to match the custom title (FormatBar), use hexpand = true to avoid width changes when changing project.

Only problem with this is that it pushes the undo button to the right, next to the FormatBar.

[hanaral]

I think it might just be necessary to expand to like 8 letters and then ellipsise the rest, considering it could just show the full name on hover.

[jeremypw]

@danrabbit in your issue report #991, what is in the right-hand half of the button - I cannot quite read your illustration. Is it the current branch name with a popover list of available branches? Have you decided about closing/hiding/collapsing non-active projects? Should documents from non-active projects remain open?

[jeremypw]

@hanaral The button now displays max 24 chars, which should be enough for most repos, and ellipsizes if not. May as well show the full path to the repo in the tooltip as when dealing with forks there may be two repos with the same name.

[jeremypw]

Ellipsized project name

[danirabbit]

Working my way through here, this is a good direction!

I appreciate the search entry since I often have a lot of projects open

One regression I noticed is that I can no longer use global search on projects which aren't using Git

In my mockup I had an idea of maybe a linked button for choosing the git branch, but that idea can wait for a follow up since there is already a way to change the branch.

Can now search non-git projects

[jeremypw]

@danrabbit Do we need to address what to do with non-active projects and documents or can we leave that to another PR?

One problem as it is, is that if you change the active project with the button it immediately reverts back to the original project as soon as the current document is refocussed, because the active project is kept in sync with the current document.

[danirabbit]

Yeah, let's leave that case for follow up. Merging this would unblock a lot of other work already, so I'm happy to get it in and we can iterate :)