Fix check for outdated Rust library #17861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This failed when install with poetry, so let's properly try and detect what's going on.
| @@ -0,0 +1 @@ | |||
| Fix detection when the built Rust library was outdated when using source installations. | |||
There was a problem hiding this comment.
This failed when install with poetry, so let's properly try and detect what's going on.
What's the testing strategy for this?
- Create a new directory
poetry new synapse-pr-17861-testcd synapse-pr-17861-testpoetry add synapse(but install from this branch)- ...
There was a problem hiding this comment.
This is for source check outs, so run poetry install -E "all test" in a checkout of this branch. Then python -c "import synapse" should work, while if you edit a rust source file it should then fail.
There was a problem hiding this comment.
Looks good ✅
Test what happens before this change:
git clone [email protected]:element-hq/synapse.git synapse-pr-17861-testcd synapse-pr-17861-testpoetry install --extras allpoetry run python -c "import synapse"(works as expected)- Make an edit to one of the rust files like
rust/src/http.rs poetry run python -c "import synapse"(works when it shouldn't ❌)
Test how this PR fixes things:
git checkout erikj/fix_outdated_rust_detection- Actually complains about dirty Rust source files (worked as expected)
$ poetry run python -c "import synapse" Traceback (most recent call last): File "<string>", line 1, in <module> File "/home/eric/Downloads/synapse-pr-17861-test2/synapse/__init__.py", line 107, in <module> check_rust_lib_up_to_date() File "/home/eric/Downloads/synapse-pr-17861-test2/synapse/util/rust.py", line 51, in check_rust_lib_up_to_date raise Exception("Rust module outdated. Please rebuild using `poetry install`") Exception: Rust module outdated. Please rebuild using `poetry install`
- Re-install as instructed to rebuild rust:
poetry install --extras all poetry run python -c "import synapse"(works as expected ✅)
MadLittleMods
approved these changes
Oct 29, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This failed when install with poetry, so let's properly try and detect what's going on.