Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise notifier #17765

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Optimise notifier #17765

merged 5 commits into from
Sep 30, 2024

Commits on Sep 27, 2024

  1. Move metrics out of hot path 

    We can update the counter once outside of the loop.
    @erikjohnston
    erikjohnston committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a3f8ec2 View commit details
    Browse the repository at this point in the history

  2. Calculate new current token once 

    Turns out doing `.copy_and_advance` can be expensive
    @erikjohnston
    erikjohnston committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    9d3e8d7 View commit details
    Browse the repository at this point in the history

  3. Newsfile

    @erikjohnston
    erikjohnston committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6452e22 View commit details
    Browse the repository at this point in the history

  4. Fix typing tests

    @erikjohnston
    erikjohnston committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e85f8f7 View commit details
    Browse the repository at this point in the history

  5. Fix up doc string

    @erikjohnston
    erikjohnston committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    210f76f View commit details
    Browse the repository at this point in the history