Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor perf speed up for large accounts on SSS #17751

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Minor perf speed up for large accounts on SSS #17751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dab15bf
Minor perf speed up for large acccounts on SSS
erikjohnston Sep 24, 2024
ac3918d
Newsfile
erikjohnston Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/17751.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Minor performance increase for large accounts using sliding sync.
10 changes: 6 additions & 4 deletions synapse/handlers/sliding_sync/extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,8 @@ async def handle_previously(room_id: str) -> None:

# Now record which rooms are now up to data, and which rooms have
# pending updates to send.
new_connection_state.account_data.record_sent_rooms(relevant_room_ids)
new_connection_state.account_data.record_sent_rooms(previously_rooms.keys())
new_connection_state.account_data.record_sent_rooms(initial_rooms)
missing_updates = (
all_updates_since_the_from_token.keys() - relevant_room_ids
)
Expand Down Expand Up @@ -763,9 +764,10 @@ async def handle_previously_room(room_id: str) -> None:

room_id_to_receipt_map[room_id] = {"type": type, "content": content}

# Now we update the per-connection state to track which receipts we have
# and haven't sent down.
new_connection_state.receipts.record_sent_rooms(relevant_room_ids)
# Update the per-connection state to track which rooms we have sent
# all the receipts for.
new_connection_state.receipts.record_sent_rooms(previously_rooms.keys())
new_connection_state.receipts.record_sent_rooms(initial_rooms)

if from_token:
# Now find the set of rooms that may have receipts that we're not sending
Expand Down
Loading