Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify test_forget_when_not_left docstring #17628

Merged
merged 2 commits into from
Oct 7, 2024
+2 −1
Merged

Clarify test_forget_when_not_left docstring #17628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
953b02f
Clarify `test_forget_when_not_left` docstring
anoadragon453 Aug 29, 2024
7f0ec99
newsfile
anoadragon453 Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/17628.doc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Clarify the docstring of `test_forget_when_not_left`.
2 changes: 1 addition & 1 deletion tests/handlers/test_room_member.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ def test_leave_and_forget_last_user(self) -> None:
)

def test_forget_when_not_left(self) -> None:
"""Tests that a user cannot not forgets a room that has not left."""
"""Tests that a user cannot forget a room that they are still in."""
self.get_failure(self.handler.forget(self.alice_ID, self.room_id), SynapseError)

def test_rejoin_forgotten_by_user(self) -> None:
Expand Down
Loading