This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Improve error display for messages sent from insecure devices #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhoreg
force-pushed
the
invisible_crypto_decryption
branch
2 times, most recently
from
034cedc
to
e1081e4
Compare
|
Ah. Forgot that SonarCloud doesn't take into account the end-to-end tests, so I'll have to add jest tests. |
uhoreg
force-pushed
the
invisible_crypto_decryption
branch
from
e1081e4
to
9afdc75
Compare
uhoreg
commented
Sep 18, 2024
richvdh
reviewed
Sep 18, 2024
richvdh
suggested changes
Sep 18, 2024
uhoreg
force-pushed
the
invisible_crypto_decryption
branch
from
de8c5fb
to
c2fc124
Compare
|
A couple of issue with this PR:
|
|
We should check whether this get counted in the PostHog stats. I suspect it does, and we should probably track it as a separate code. |
richvdh
force-pushed
the
invisible_crypto_decryption
branch
from
c2fc124
to
076f097
Compare
richvdh
changed the title
richvdh
changed the title
richvdh
force-pushed
the
invisible_crypto_decryption
branch
from
076f097
to
72649d2
Compare
richvdh
force-pushed
the
invisible_crypto_decryption
branch
from
72649d2
to
777be6f
Compare
Add a labs option which will, when set, switch into the "invisible crypto" mode of refusing to send keys to, or decrypt messages from, devices that have not been signed by their owner.
Improve the error messages shown for messages from insecure devices.
richvdh
force-pushed
the
invisible_crypto_decryption
branch
from
777be6f
to
4940648
Compare
Filed as element-hq/element-meta#2541 |
|
Closing in favour of #93 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#92 provides a mode in which we will reject:
This PR improves the display of both kinds of message.
The former is shown like this:
The latter is shown like this:
This is based on the designs at element-hq/element-meta#2523, but we don't yet show the content of the event (that being the point of element-hq/element-meta#2523).
Checklist
public/exportedsymbols have accurate TSDoc documentation.