This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Playwright test for E2E messages from deleted devices #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to MSC4147, we now have information on the devices that sent messages, even when the device has since been deleted. Test that out.
andybalaam
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Looks good - one possibility.
To test the SenderData stuff fully, we would need to check the behaviour when a user who is verified, unverified, or previously-verified sends a message from a verified device.
Is there any user-visible difference in those cases?
There is no difference between "verified" and "unverified" users. I guess I could add some tests around "previously-verified". |
florianduros
approved these changes
Sep 17, 2024
|
previously-verified users don't make much difference here either: we don't distinguish (yet) between messages sent from verified, previously-verified, and unverified users. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test what happens when we receive a message from a device which has since been deleted.
Hopefully, fixes element-hq/element-meta#2517