-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker image improvements #655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned elsewhere, I don't think we want to load the config file like this. Why did you need to change it?
Apart from that, I don't know much about Docker, so can't really review that. If you're confident that these changes to the docker setup are an improvement and won't break, I'm happy to merge them.
This change is here to be able to change the config without rebuilding the app. Currently, the config lives in the bundled JS, which makes it impossible to change without rebuilding the app. This allows to have on the filesystem a plain old The end result, is that one can run the image with a custom default homeserver without having to build a custom one:
If that is not desirable, I can move the config handling changes in another PR and merge the docker improvements first |
Thanks, that would be good. |
54572ce
to
073d2f7
Compare
073d2f7
to
efbfe48
Compare
efbfe48
to
e61a914
Compare
f4d0ba3
to
66851ba
Compare
66851ba
to
6ebb058
Compare
Closing this in preference to the following smaller PRs:
I've parked running nginx as non-root for now. |
The commits are individually reviewable. This includes:
TARGETPLATFORM
andBUILDPLATFORM
build args for doing the bundling under the host arch/tmp
, e.g.docker run --publish 80:8080 --read-only --volume tmp:/tmp hydrogen
config.json
templated from environment variables