Use the existing quote bubble layout with TimelineReplyView. #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
requested review from
Velin92 and
stefanceriu
and removed request for
a team and
Velin92
pixlwave
force-pushed
the
doug/reply-bubbles
branch
from
b180023
to
1a9d809
Compare
Generated by 🚫 Danger Swift against 1a9d809 |
|
Kudos, SonarCloud Quality Gate passed!
|
stefanceriu
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #861, this PR uses the existing layout and formatting from
FormattedBodyTextfor the newTimelineReplyViewwhen contained within a message bubble. The result should be the same layout as we had before, but now with the sender's name formatted as in the Figma: