Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login and server selection screens #651

Merged
merged 8 commits into from
Mar 2, 2023
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Feb 28, 2023

Fixes #632.

Additionally tidies up some uses of the old NavigationView, opting for NavigationStack instead.

Login Screen Server Selection Screen
Simulator Screen Shot - iPhone 14 - 2023-03-02 at 12 49 16 Simulator Screen Shot - iPhone 14 - 2023-03-02 at 18 08 09

@pixlwave pixlwave requested review from a team and stefanceriu and removed request for a team February 28, 2023 13:27
@github-actions
Copy link

github-actions bot commented Feb 28, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against adc5f0d

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 👍

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 16.50% and project coverage change: -0.31 ⚠️

Comparison is base (e7a8dc8) 52.22% compared to head (adc5f0d) 51.91%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #651      +/-   ##
===========================================
- Coverage    52.22%   51.91%   -0.31%     
===========================================
  Files          259      259              
  Lines        14157    14193      +36     
  Branches      9090     9098       +8     
===========================================
- Hits          7393     7369      -24     
- Misses        6542     6602      +60     
  Partials       222      222              
Flag Coverage Δ
unittests 20.80% <16.50%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Kit/Sources/TextFields/ElementTextFieldStyle.swift 51.66% <0.00%> (-15.00%) ⬇️
...creens/AnalyticsPrompt/AnalyticsPromptModels.swift 58.33% <0.00%> (-9.85%) ⬇️
...reens/Authentication/AuthenticationIconImage.swift 40.00% <0.00%> (-38.58%) ⬇️
.../Authentication/LoginScreen/View/LoginScreen.swift 73.68% <0.00%> (-7.27%) ⬇️
...tion/LoginScreen/View/LoginServerInfoSection.swift 83.33% <0.00%> (-3.34%) ⬇️
...n/ServerSelection/View/ServerSelectionScreen.swift 78.20% <0.00%> (-6.61%) ⬇️
...hentication/SoftLogout/View/SoftLogoutScreen.swift 63.51% <0.00%> (-3.87%) ⬇️
...X/Sources/Screens/Authentication/UIConstants.swift 100.00% <ø> (ø)
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift 63.31% <0.00%> (ø)
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 63.44% <0.00%> (+2.61%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pixlwave pixlwave mentioned this pull request Mar 2, 2023
@callumu
Copy link

callumu commented Mar 2, 2023

Some comments:

  1. Copy should be 'Email or username'
  2. Could you check the size of the server icon and match it to the design?
  3. The copy size of 'What is the address of your server?' should be smaller and 15px

@pixlwave
Copy link
Member Author

pixlwave commented Mar 2, 2023

@callumu Updated (using just Username as discussed as signing in with an email doesn't work).

@callumu
Copy link

callumu commented Mar 2, 2023

This looks great, thanks

@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pixlwave pixlwave merged commit 1c09a7e into develop Mar 2, 2023
@pixlwave pixlwave deleted the doug/632-login-screen branch March 2, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log in screen adjustments
4 participants