-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update login and server selection screens #651
Conversation
Generated by 🚫 Danger Swift against adc5f0d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff 👍
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #651 +/- ##
===========================================
- Coverage 52.22% 51.91% -0.31%
===========================================
Files 259 259
Lines 14157 14193 +36
Branches 9090 9098 +8
===========================================
- Hits 7393 7369 -24
- Misses 6542 6602 +60
Partials 222 222
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Some comments:
|
a2ded0d
to
5f2e7d9
Compare
@callumu Updated (using just |
This looks great, thanks |
5f2e7d9
to
bfb51f5
Compare
Top spacing and strings.
bfb51f5
to
e47d368
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #632.
Additionally tidies up some uses of the old
NavigationView
, opting forNavigationStack
instead.