Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design: Forms, Login and Members screen. #608

Merged
merged 7 commits into from
Feb 22, 2023
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Feb 21, 2023

This PR makes the following changes:

  • Fixes the login screen being blocked by a loading indicator when entering a full MXID.
  • Fixes the text field placeholders occasionally flickering on the login screen.
  • Adds a pressed state to all buttons in Form components.
  • Removes some unnecessary disclosure indicators from buttons that don't push screens in Settings.
  • Disables scrolling on the skeletons on the home screen.
  • Fixes form icons to actually be square.
  • Renames the various Settings Styles/Components to be more generic Form Styles.
  • Removes SettingsDefaultRow and SettingsPickerRow in favour of using the standard components with form styles applies.
  • Adds a formSectionStyle modifier that will correctly colour and inset form sections.

Fixes #602
Fixes #583

Simulator.Screen.Recording.-.iPhone.14.-.2023-02-22.at.10.26.59.mp4

@github-actions
Copy link

github-actions bot commented Feb 21, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against ceb996e

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 52.69% // Head: 51.73% // Decreases project coverage by -0.96% ⚠️

Coverage data is based on head (ceb996e) compared to base (7d5d801).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #608      +/-   ##
===========================================
- Coverage    52.69%   51.73%   -0.96%     
===========================================
  Files          256      259       +3     
  Lines        13784    13916     +132     
  Branches      9070     9096      +26     
===========================================
- Hits          7263     7199      -64     
- Misses        6313     6510     +197     
+ Partials       208      207       -1     
Flag Coverage Δ
unittests 20.86% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/Other/SwiftUI/Form Styles/FormButtonStyles.swift 0.00% <0.00%> (ø)
.../Other/SwiftUI/Form Styles/FormRowLabelStyle.swift 0.00% <0.00%> (ø)
...ources/Other/SwiftUI/Form Styles/FormSection.swift 0.00% <0.00%> (ø)
.../Authentication/LoginScreen/LoginCoordinator.swift 71.89% <0.00%> (-3.93%) ⬇️
.../Authentication/LoginScreen/View/LoginScreen.swift 73.01% <0.00%> (-6.65%) ⬇️
...urces/Screens/BugReport/View/BugReportScreen.swift 72.29% <0.00%> (-7.85%) ⬇️
...ionsScreen/View/DeveloperOptionsScreenScreen.swift 0.00% <0.00%> (ø)
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift 60.10% <0.00%> (-0.86%) ⬇️
...s/Screens/RoomDetails/View/RoomDetailsScreen.swift 60.99% <0.00%> (-20.09%) ⬇️
...ens/RoomMembers/View/RoomMemberDetailsScreen.swift 55.55% <0.00%> (-1.59%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pixlwave pixlwave marked this pull request as ready for review February 22, 2023 10:28
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too 👏

@pixlwave pixlwave merged commit 246879f into develop Feb 22, 2023
@pixlwave pixlwave deleted the doug/design-tweaks branch February 22, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design Tweaks: Room Members (People) page dark mode background colour
3 participants