-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design: Forms, Login and Members screen. #608
Conversation
dc76d32
to
f630cfc
Compare
Generated by 🚫 Danger Swift against ceb996e |
Codecov ReportBase: 52.69% // Head: 51.73% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #608 +/- ##
===========================================
- Coverage 52.69% 51.73% -0.96%
===========================================
Files 256 259 +3
Lines 13784 13916 +132
Branches 9070 9096 +26
===========================================
- Hits 7263 7199 -64
- Misses 6313 6510 +197
+ Partials 208 207 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cc190c0
to
ceb996e
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm too 👏
This PR makes the following changes:
SettingsDefaultRow
andSettingsPickerRow
in favour of using the standard components with form styles applies.formSectionStyle
modifier that will correctly colour and inset form sections.Fixes #602
Fixes #583
Simulator.Screen.Recording.-.iPhone.14.-.2023-02-22.at.10.26.59.mp4