Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the timeline to correctly fix it to the bottom in UI tests. #553

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Feb 8, 2023

Change log covered by #534.

@pixlwave pixlwave requested a review from Velin92 February 8, 2023 17:40
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against f56aa7c

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 40.61% // Head: 40.53% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (f56aa7c) compared to base (22a9948).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #553      +/-   ##
===========================================
- Coverage    40.61%   40.53%   -0.09%     
===========================================
  Files          292      292              
  Lines        16945    16981      +36     
  Branches     11308    11314       +6     
===========================================
  Hits          6883     6883              
- Misses        9746     9780      +34     
- Partials       316      318       +2     
Flag Coverage Δ
unittests 21.02% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../RoomScreen/View/TimelineTableViewController.swift 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Velin92 Velin92 merged commit f7fbdcc into develop Feb 8, 2023
@Velin92 Velin92 deleted the doug/more-tests branch February 8, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants