Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towncrier PR tests. #47

Merged
merged 1 commit into from
May 11, 2022
Merged

Towncrier PR tests. #47

merged 1 commit into from
May 11, 2022

Conversation

stefanceriu
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented May 9, 2022

Warnings
⚠️ Please provide a description for this PR.
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against f2db79b

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #47 (f2db79b) into develop (fdbb0fc) will not change coverage.
The diff coverage is n/a.

❗ Current head f2db79b differs from pull request most recent head 0a97ddb. Consider uploading reports for the commit 0a97ddb to get more accurate results

@@           Coverage Diff           @@
##           develop     #47   +/-   ##
=======================================
  Coverage     6.22%   6.22%           
=======================================
  Files           86      86           
  Lines         7449    7449           
  Branches      4027    4027           
=======================================
  Hits           464     464           
  Misses        6979    6979           
  Partials         6       6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdbb0fc...0a97ddb. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 9, 2022

Changes in 47 (2022-05-11)

🙌 Improvements

  • Spaces: Bring leaving space experience in line with Web (#4850)
  • Location sharing: Add cell for live location sharing in timeline (#6029)
  • Location sharing: Add timer selector when start live location sharing (#6071)
  • Location sharing: Connect SDK to location sharing timeline cell (#6077)

🐛 Bugfixes

  • RoomNavigationParameters: Fix initializer by not defining convenience. (#5883)
  • Fail to open a sub space (#5965)
  • RecentsViewController: Fix disappearing filter on search cancellation & empty view on the first screen appearing. (#6076)
  • RoomsViewController: Avoid crash by fixing section index to scroll. (#6086)
  • Search: Prevent crash when searching (#6115)

🗣 Translations

  • Localisations: Remove strings with bad formatting and add a run script to detect errors at compile time. (#5990)

🧱 Build

  • UI Tests: Fix broken tests and add a check on PRs. (#6050)

🚧 In development 🚧

  • Authentication: Begin implementing authentication flow with a Service, Registration screen and Server Selection screen. (#5648)
  • Location sharing: Add live location viewer screen. (#5723)
  • Location sharing: Support live location event in the timeline. (#6057)

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/zWrwwZ

@stefanceriu stefanceriu force-pushed the stefan/towncrier branch 17 times, most recently from 3ff9105 to aa71b00 Compare May 11, 2022 06:25
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu merged commit db1114d into develop May 11, 2022
@stefanceriu stefanceriu deleted the stefan/towncrier branch May 11, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants