Fastlane fails resetting the right simulator, use device instead of destination.

[stefanceriu]

This seems to have worked for the integration tests https://github.com/element-hq/element-x-ios/actions/runs/11718009383/job/32638954449, let's hope it works for the others too.

[07:50:30]: Cruising over to lane 'create_simulator_if_necessary' 🚖
[07:50:30]: --------------------------------------------------------------------
[07:50:30]: Step: xcrun simctl list devices | grep 'iPhone 16 Pro (18.0) ('
[07:50:30]: --------------------------------------------------------------------
[07:50:30]: $ xcrun simctl list devices | grep 'iPhone 16 Pro (18.0) ('
[07:50:30]: --------------------------------------------------------------------
[07:50:30]: Step: xcrun simctl create 'iPhone 16 Pro (18.0)' com.apple.CoreSimulator.SimDeviceType.iPhone-16-Pro com.apple.CoreSimulator.SimRuntime.iOS-18-0
[07:50:30]: --------------------------------------------------------------------
[07:50:30]: $ xcrun simctl create 'iPhone 16 Pro (18.0)' com.apple.CoreSimulator.SimDeviceType.iPhone-16-Pro com.apple.CoreSimulator.SimRuntime.iOS-18-0

[07:51:15]: Resetting iPhone 16 Pro
[07:51:15]: Disabling 'Slide to Type' iPhone 16 Pro

[github-actions]

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against d6d5241

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
899	1	898	0

View the full list of 1 ❄️ flaky tests

RoomScreenViewModelTests testPinnedEventsBanner()

Flake rate in main: 23.95% (Passed 181 times, Failed 57 times)

Stack Traces | 16.5s run time

Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud