Add alias to public room creation #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into mauroromito/add_alias_to_room_creation
Generated by 🚫 Danger Swift against 01c7f3e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3450 +/- ##
===========================================
+ Coverage 78.66% 78.74% +0.08%
===========================================
Files 743 743
Lines 61601 61906 +305
===========================================
+ Hits 48458 48750 +292
- Misses 13143 13156 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…into mauroromito/add_alias_to_room_creation # Conflicts: # ElementX/Resources/Localizations/en.lproj/Localizable.strings # ElementX/Sources/Generated/Strings.swift
…into mauroromito/add_alias_to_room_creation
…into mauroromito/add_alias_to_room_creation # Conflicts: # ElementX/Sources/Services/Client/ClientProxy.swift
Velin92
added
the
pr-wip
…into mauroromito/add_alias_to_room_creation
pixlwave
approved these changes
Nov 7, 2024
ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/CreateRoom/View/CreateRoomScreen.swift
Outdated
Show resolved
Hide resolved
…into mauroromito/add_alias_to_room_creation
…into mauroromito/add_alias_to_room_creation
…into mauroromito/add_alias_to_room_creation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3419
And update the SDK to fix some bugs on the availability and validity API, but should not impact the current iOS code.
Simulator.Screen.Recording.-.iPhone.16.-.2024-11-07.at.17.43.25.mp4