Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rendering media captions in the timeline. #3429

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 18, 2024

Should bring EXI into parity with EXA regarding captions. Part of https://github.com/element-hq/element-internal/issues/637 which I now remember needs to be broken down into tasks still.

Caption!
Simulator Screenshot - iPhone 16 Pro - 2024-10-18 at 16 46 36

@pixlwave pixlwave requested a review from a team as a code owner October 18, 2024 15:47
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 18, 2024 15:47
Copy link

github-actions bot commented Oct 18, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 9e2586d

@pixlwave pixlwave added the pr-change for updates to an existing feature label Oct 18, 2024
Copy link

sonarcloud bot commented Oct 18, 2024

Copy link

codecov bot commented Oct 18, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
846 3 843 0
View the top 1 failed tests by shortest run time
PreviewTests test_roomDetailsEditScreen()
Stack Traces | 2.23s run time
failed - Snapshot "Editable" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomDetailsEditScreen-iPhone-16-en-GB.Editable.png"
@+
"file:.../tmp/PreviewTests/test_roomDetailsEditScreen-iPhone-16-en-GB.Editable.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8510742 is less than required 1.0
The lowest perceptual color precision 0.016250014 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
View the full list of 2 ❄️ flaky tests
PreviewTests test_identityConfirmationScreen()

Flake rate in main: 21.19% (Passed 212 times, Failed 57 times)

Stack Traces | 1.44s run time
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_identityConfirmationScreen-iPhone-16-en-GB.1.png"
@+
"file:.../tmp/PreviewTests/test_identityConfirmationScreen-iPhone-16-en-GB.1.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.89941406 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_userProfileScreen()

Flake rate in main: 14.29% (Passed 66 times, Failed 11 times)

Stack Traces | 6s run time
failed - Snapshot "Other User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Other-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Other-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9088135 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@pixlwave pixlwave merged commit a0c81cf into develop Oct 21, 2024
13 checks passed
@pixlwave pixlwave deleted the doug/timeline-media-captions branch October 21, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants