Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask the iPad to reveal the keyboard in UI Tests when it's hidden. #3389

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Ask the iPad to reveal the keyboard in UI Tests when it's hidden. #3389

merged 1 commit into from
Oct 10, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Oct 9, 2024 •
edited
Loading

Finally a successful run since upgrading to Xcode 16 🥳

https://github.com/element-hq/element-x-ios/actions/runs/11259522717

Thanks for all the help @manuroe!

@pixlwave pixlwave requested a review from a team as a code owner October 9, 2024 17:22
@pixlwave pixlwave requested review from Velin92 and removed request for a team October 9, 2024 17:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against c409b16

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@5c2b107). Learn more about missing BASE report.
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #3389   +/-   ##
==========================================
  Coverage           ?   77.49%           
==========================================
  Files              ?      740           
  Lines              ?    60231           
  Branches           ?        0           
==========================================
  Hits               ?    46676           
  Misses             ?    13555           
  Partials           ?        0
Flag Coverage Δ
unittests 68.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stefanceriu
stefanceriu approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yey! 👏

@pixlwave pixlwave added the pr-misc for other changes label Oct 10, 2024
@pixlwave pixlwave merged commit 429ce4f into develop Oct 10, 2024
13 checks passed
@pixlwave pixlwave deleted the doug/ui-tests-keyboard branch October 10, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

@Velin92 Velin92 Awaiting requested review from Velin92 Velin92 is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
pr-misc for other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @stefanceriu