Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kingfisher to fix a bug that prevented GIFs from being tapped. #3326

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

pixlwave
Copy link
Member

For more info see onevcat/Kingfisher#2295

@pixlwave pixlwave requested a review from a team as a code owner September 24, 2024 16:23
@pixlwave pixlwave requested review from Velin92 and removed request for a team September 24, 2024 16:23
@pixlwave pixlwave changed the title Upgrade Kingfisher to fix a bug the prevented GIFs from being tapped. Upgrade Kingfisher to fix a bug that prevented GIFs from being tapped. Sep 24, 2024
@pixlwave pixlwave added the pr-bugfix for bug fix label Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against d689025

Copy link

codecov bot commented Sep 24, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
824 1 823 0
View the full list of 1 ❄️ flaky tests
RoomScreenViewModelTests testPinnedEventsBanner()

Flake rate in main: 9.09% (Passed 10 times, Failed 1 times)

Stack Traces | 10.2s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link

sonarcloud bot commented Sep 25, 2024

@pixlwave
Copy link
Member Author

Another timeout failure.

@pixlwave pixlwave merged commit af8c161 into develop Sep 25, 2024
6 of 7 checks passed
@pixlwave pixlwave deleted the doug/gif-hit-testing branch September 25, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants