Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the new iPad modal presentation mode for the timeline item menu #3325

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

pixlwave
Copy link
Member

There are other sheets that have been shrunk with Xcode 16, but this one looks really bad with the new size and is the one people will see most of the time, so fixing this before making the RC.

@pixlwave pixlwave requested a review from a team as a code owner September 24, 2024 12:57
@pixlwave pixlwave requested review from stefanceriu and removed request for a team September 24, 2024 12:57
Copy link

github-actions bot commented Sep 24, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 3cf8688

@pixlwave pixlwave added the pr-bugfix for bug fix label Sep 24, 2024
Copy link

sonarcloud bot commented Sep 24, 2024

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@c264e9e). Learn more about missing BASE report.
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...eens/Timeline/View/ItemMenu/TimelineItemMenu.swift 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3325   +/-   ##
==========================================
  Coverage           ?   77.32%           
==========================================
  Files              ?      736           
  Lines              ?    59500           
  Branches           ?        0           
==========================================
  Hits               ?    46006           
  Misses             ?    13494           
  Partials           ?        0           
Flag Coverage Δ
unittests 68.41% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit f772849 into develop Sep 24, 2024
12 of 13 checks passed
@pixlwave pixlwave deleted the doug/fix-ipad-action-menu branch September 24, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants