Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable message pinning #3308

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Enable message pinning #3308

merged 1 commit into from
Sep 23, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Sep 19, 2024

enbling the FF for message pinning

@Velin92 Velin92 requested a review from a team as a code owner September 19, 2024 14:52
@Velin92 Velin92 requested review from stefanceriu and removed request for a team September 19, 2024 14:52
@Velin92 Velin92 added the pr-feature for a new feature label Sep 19, 2024
Copy link

github-actions bot commented Sep 19, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 97725ef

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, presumably we'll remove the flag in a follow-up?

@Velin92
Copy link
Member Author

Velin92 commented Sep 19, 2024

LGTM, presumably we'll remove the flag in a follow-up?

yup

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.49%. Comparing base (da6487e) to head (97725ef).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3308      +/-   ##
===========================================
- Coverage    77.49%   77.49%   -0.01%     
===========================================
  Files          735      735              
  Lines        59475    59475              
===========================================
- Hits         46092    46090       -2     
- Misses       13383    13385       +2     
Flag Coverage Δ
unittests 68.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 force-pushed the mauroromito/enable_message_pinning branch from 9f4e440 to 97725ef Compare September 23, 2024 07:51
@Velin92 Velin92 merged commit adfd41a into develop Sep 23, 2024
5 checks passed
@Velin92 Velin92 deleted the mauroromito/enable_message_pinning branch September 23, 2024 07:51
Copy link

sonarcloud bot commented Sep 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants