Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ClientBuilder hook. #3056

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Add a ClientBuilder hook. #3056

merged 1 commit into from
Jul 18, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 17, 2024

This PR adds an app hook for modifying the default ClientBuilder . Additionally it adds the necessary setup for app hooks in the NSE (making the hook availability conditional depending on the target).

@pixlwave pixlwave requested a review from a team as a code owner July 17, 2024 15:29
@pixlwave pixlwave requested review from Velin92 and removed request for a team July 17, 2024 15:29
@pixlwave pixlwave added the pr-misc for other changes label Jul 17, 2024
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 249d435

Copy link

sonarcloud bot commented Jul 17, 2024

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 77.76%. Comparing base (95d53f1) to head (249d435).

Files Patch % Lines
ElementX/Sources/Application/AppCoordinator.swift 0.00% 7 Missing ⚠️
ElementX/Sources/Hooks/AppHooks.swift 0.00% 7 Missing ⚠️
...X/Sources/Services/QRCode/QRCodeLoginService.swift 0.00% 6 Missing ⚠️
...ervices/Authentication/AuthenticationService.swift 0.00% 4 Missing ⚠️
...ources/Services/UserSession/UserSessionStore.swift 0.00% 4 Missing ⚠️
NSE/Sources/NotificationServiceExtension.swift 0.00% 3 Missing ⚠️
NSE/Sources/Other/NSEUserSession.swift 0.00% 3 Missing ⚠️
...mentX/Sources/Other/Extensions/ClientBuilder.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3056      +/-   ##
===========================================
- Coverage    77.76%   77.76%   -0.01%     
===========================================
  Files          695      695              
  Lines        54110    54128      +18     
===========================================
+ Hits         42078    42091      +13     
- Misses       12032    12037       +5     
Flag Coverage Δ
unittests 68.64% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 288d2c2 into develop Jul 18, 2024
12 checks passed
@pixlwave pixlwave deleted the doug/builder-hook branch July 18, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants