Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RTE with inline prediction working #3043

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jul 15, 2024

This new version of RTE re-enables inline predictive text and fixes a bunch of issues with it.

@Velin92 Velin92 requested a review from a team as a code owner July 15, 2024 15:50
@Velin92 Velin92 requested review from pixlwave and removed request for a team July 15, 2024 15:50
@Velin92 Velin92 changed the title Update RTE with inline prediction working well Update RTE with inline prediction working Jul 15, 2024
Copy link

github-actions bot commented Jul 15, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 2b4dd47

@Velin92 Velin92 added the pr-misc for other changes label Jul 15, 2024
Copy link

sonarcloud bot commented Jul 15, 2024

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.93%. Comparing base (f9d107c) to head (2b4dd47).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3043   +/-   ##
========================================
  Coverage    77.92%   77.93%           
========================================
  Files          695      695           
  Lines        53997    53997           
========================================
+ Hits         42079    42080    +1     
+ Misses       11918    11917    -1     
Flag Coverage Δ
unittests 68.76% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Velin92 Velin92 merged commit 812552c into develop Jul 15, 2024
12 checks passed
@Velin92 Velin92 deleted the mauroromito/rte_2_37_6 branch July 15, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants