Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use local room list sorting from Rust. #2978

Merged
merged 6 commits into from
Jul 5, 2024
Merged

Use local room list sorting from Rust. #2978

merged 6 commits into from
Jul 5, 2024

Conversation

stefanceriu
Copy link
Member

  • adopt the new SDK side local room list sorting API
  • replace the old RoomSummary enum with plain details

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 507e951

@pixlwave pixlwave force-pushed the stefan/localRoomListSorting branch 2 times, most recently from 40fa132 to 86b9a3c Compare July 4, 2024 16:13
@pixlwave pixlwave added the pr-change for updates to an existing feature label Jul 4, 2024
@pixlwave pixlwave changed the title Local room list sorting Use local room list sorting from Rust. Jul 4, 2024
@pixlwave
Small tidy up post rebase/review.
a0c0682 
- Remove unused invalidated property.
- Rename some RoomSummary instances to summary instead of details.
- Fix tests with missing roomListItem's.
@pixlwave pixlwave force-pushed the stefan/localRoomListSorting branch from 86b9a3c to a0c0682 Compare July 4, 2024 16:43
pixlwave
pixlwave approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems decent to me. I guess my comments are in the "Tidy up" commit 😅

@pixlwave pixlwave marked this pull request as ready for review July 4, 2024 16:46
@pixlwave pixlwave requested a review from a team as a code owner July 4, 2024 16:46
@pixlwave pixlwave requested review from Velin92 and removed request for a team July 4, 2024 16:46
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 46 lines in your changes missing coverage. Please review.

Project coverage is 77.80%. Comparing base (c024702) to head (507e951).

Files Patch % Lines
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 0.00% 46 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2978      +/-   ##
===========================================
- Coverage    77.92%   77.80%   -0.12%     
===========================================
  Files          694      695       +1     
  Lines        53939    53847      -92     
===========================================
- Hits         42032    41897     -135     
- Misses       11907    11950      +43
Flag Coverage Δ
unittests 68.62% <77.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit d71c8c4 into develop Jul 5, 2024
10 checks passed
@pixlwave pixlwave deleted the stefan/localRoomListSorting branch July 5, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@Velin92 Velin92 Awaiting requested review from Velin92 Velin92 is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
pr-change for updates to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave