-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plain composer suggestions and pills #2751
Conversation
stefanceriu
commented
Apr 26, 2024
- allow user suggestions on the plain composer
- render pills within it for supported permalinks
- intentional mention support
- various other small tweaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wooop 👏
@@ -26,6 +26,11 @@ enum UserIDAttribute: AttributedStringKey { | |||
static var name = "MXUserIDAttribute" | |||
} | |||
|
|||
enum UserDisplayNameAttribute: AttributedStringKey { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth adding a doc as to why we have both UserID and UserDisplayName attributes.
ElementX/Sources/Screens/ComposerToolbar/CompletionSuggestionServiceProtocol.swift
Outdated
Show resolved
Hide resolved
b355817
to
d803850
Compare
Generated by 🚫 Danger Swift against 4ab7439 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2751 +/- ##
===========================================
- Coverage 74.93% 73.49% -1.44%
===========================================
Files 582 597 +15
Lines 40896 42682 +1786
===========================================
+ Hits 30644 31368 +724
- Misses 10252 11314 +1062
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…not a screen on its own)
…and use it for mention building
b201bab
to
4ab7439
Compare
Quality Gate passedIssues Measures |
That drop in coverage seems very wrong for the size of this patch. Lets merge and see what happens once we have UI/integration test runs too. |