Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plain composer suggestions and pills #2751

Merged
merged 8 commits into from
May 3, 2024
Merged

Conversation

stefanceriu
Copy link
Member

  • allow user suggestions on the plain composer
  • render pills within it for supported permalinks
  • intentional mention support
  • various other small tweaks

@stefanceriu stefanceriu requested a review from a team as a code owner April 26, 2024 12:30
@stefanceriu stefanceriu requested review from pixlwave and Velin92 and removed request for a team April 26, 2024 12:30
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooop 👏

@@ -26,6 +26,11 @@ enum UserIDAttribute: AttributedStringKey {
static var name = "MXUserIDAttribute"
}

enum UserDisplayNameAttribute: AttributedStringKey {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a doc as to why we have both UserID and UserDisplayName attributes.

@pixlwave pixlwave force-pushed the stefan/plainComposerPills branch from b355817 to d803850 Compare May 2, 2024 16:26
Copy link

github-actions bot commented May 2, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4ab7439

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 37.11340% with 122 lines in your changes are missing coverage. Please review.

Project coverage is 73.49%. Comparing base (d067e84) to head (4ab7439).

Files Patch % Lines
...een/ComposerToolbar/ComposerToolbarViewModel.swift 22.78% 61 Missing ⚠️
...omposerToolbar/View/MessageComposerTextField.swift 38.88% 22 Missing ⚠️
.../ComposerToolbar/CompletionSuggestionService.swift 47.50% 21 Missing ⚠️
ElementX/Sources/Other/Pills/MentionBuilder.swift 14.28% 6 Missing ⚠️
...rToolbar/CompletionSuggestionServiceProtocol.swift 53.84% 6 Missing ⚠️
...Screen/ComposerToolbar/ComposerToolbarModels.swift 33.33% 2 Missing ⚠️
...mScreen/ComposerToolbar/View/ComposerToolbar.swift 50.00% 2 Missing ⚠️
...entX/Sources/Other/Pills/PlainMentionBuilder.swift 0.00% 1 Missing ⚠️
...mScreen/ComposerToolbar/View/MessageComposer.swift 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2751      +/-   ##
===========================================
- Coverage    74.93%   73.49%   -1.44%     
===========================================
  Files          582      597      +15     
  Lines        40896    42682    +1786     
===========================================
+ Hits         30644    31368     +724     
- Misses       10252    11314    +1062     
Flag Coverage Δ
unittests 62.17% <37.11%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave force-pushed the stefan/plainComposerPills branch from b201bab to 4ab7439 Compare May 2, 2024 17:18
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pixlwave
Copy link
Member

pixlwave commented May 3, 2024

That drop in coverage seems very wrong for the size of this patch. Lets merge and see what happens once we have UI/integration test runs too.

@pixlwave pixlwave merged commit 38416db into develop May 3, 2024
8 of 9 checks passed
@pixlwave pixlwave deleted the stefan/plainComposerPills branch May 3, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants