Don't pass a URL as a log destination to rust #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS (catalyst) URL.appGroupContainerDirectory returns: /Users/matthew/Library/Group%20Containers/group.io.element/ So you need to strip the %20 out into a space, otherwise logging fails with a permissions error.
Generated by 🚫 Danger Swift against 6b7a304 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2506 +/- ##
===========================================
+ Coverage 74.63% 74.69% +0.05%
===========================================
Files 533 529 -4
Lines 37110 36974 -136
Branches 17679 17495 -184
===========================================
- Hits 27697 27616 -81
+ Misses 9196 9140 -56
- Partials 217 218 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
approved these changes
Feb 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS (catalyst)
URL.appGroupContainerDirectoryreturns:/Users/matthew/Library/Group%20Containers/group.io.element/So you need to decode the %20 back into a space, otherwise logging fails with a permissions error.
Pull Request Checklist