-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI POC for room list filters #2382
Conversation
Generated by 🚫 Danger Swift against e25698e |
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/zqCPjU |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2382 +/- ##
===========================================
- Coverage 73.20% 73.12% -0.09%
===========================================
Files 517 519 +2
Lines 35602 35780 +178
Branches 17112 17214 +102
===========================================
+ Hits 26062 26163 +101
- Misses 8909 8986 +77
Partials 631 631
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woooo nice 👌
ElementX/Sources/Screens/HomeScreen/View/Filters/FilterView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/HomeScreen/View/Filters/RoomListFiltersView.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/HomeScreen/View/Filters/RoomListFiltersView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/HomeScreen/View/Filters/FilterView.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Doug <[email protected]>
Co-authored-by: Doug <[email protected]>
…/element-x-ios into mauroromito/filters_ui
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
This is just a UI preview, the filters won't do anything yet to the room list
fixes #2339
fixes #2340
fixes #2341
Simulator.Screen.Recording.-.iPhone.15.-.2024-01-25.at.12.17.59.mp4