Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK bindings version to 0.2.62 and fix SendHandle usages #3876

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

jmartinesp
Copy link
Member

Content

  • Upgrade Rust SDK bindings version.
  • Fix SendHandle api breaks.

Motivation and context

We need a new version of the bindings.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Dependencies Pull requests that update a dependency file label Nov 15, 2024
@jmartinesp jmartinesp requested a review from a team as a code owner November 15, 2024 11:42
@jmartinesp jmartinesp requested review from ganfra and removed request for a team November 15, 2024 11:42
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/BrtMnj

Copy link

sonarcloud bot commented Nov 15, 2024

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.87%. Comparing base (918caf1) to head (875311f).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...resolve/ResolveVerifiedUserSendFailurePresenter.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3876   +/-   ##
========================================
  Coverage    82.87%   82.87%           
========================================
  Files         1784     1785    +1     
  Lines        45090    45100   +10     
  Branches      5324     5324           
========================================
+ Hits         37368    37378   +10     
  Misses        5857     5857           
  Partials      1865     1865           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 15, 2024
@jmartinesp jmartinesp enabled auto-merge (squash) November 15, 2024 13:16
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 15, 2024
@jmartinesp jmartinesp merged commit 1be7993 into develop Nov 15, 2024
33 checks passed
@jmartinesp jmartinesp deleted the misc/update-sdk-bindings-to-0.2.62 branch November 15, 2024 13:49
@frebib
Copy link
Contributor

frebib commented Nov 15, 2024

This should does fix #3843 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants