ElementCall: allow user to switch to another call. #3833
Conversation
| } else if (currentCallType == null) { | ||
| Timber.tag(loggerTag).d("Set the call type and create the presenter") | ||
| webViewTarget.value = callType | ||
| presenter = presenterFactory.create(callType!!, this) |
There was a problem hiding this comment.
Sadly i had to use !! here, the compiler is not clever enough (or is it me?)
There was a problem hiding this comment.
You could also explicitly add && callType != null to the if clause.
There was a problem hiding this comment.
Yes, but callType != null is always true in this case, so I think it's worse.
There was a problem hiding this comment.
It seems more descriptive to me, but I don't really mind 🤷♂️ .
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3833 +/- ##
===========================================
- Coverage 83.00% 82.99% -0.02%
===========================================
Files 1782 1782
Lines 44860 44873 +13
Branches 5265 5267 +2
===========================================
+ Hits 37237 37242 +5
- Misses 5789 5795 +6
- Partials 1834 1836 +2 ☔ View full report in Codecov by Sentry. |
|
Content
When the user is in a call, starting (or joining) another call had no effect.
With the change in this PR, if the Activity get a new Intent with other call data, the current call is terminated and the new call starts. Actually the Activity is recreated as it was way simpler than trying to update all the internal state.
Motivation and context
Same behavior than on the iOS app.
Screenshots / GIFs
Tests
Call A should be terminated and Call B should be started
Tested devices
Checklist