Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize media upload #3779

Merged
merged 9 commits into from
Nov 4, 2024
Merged

Optimize media upload #3779

merged 9 commits into from
Nov 4, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 31, 2024

Content

  • Wording update
  • Enable optimization by default
  • Always limit video size
  • Compress png to png

Motivation and context

element-hq/element-meta#2543

Screenshots / GIFs

See recorded ones

Tests

  • Enable or disable the new setting
  • Send media to the room and observe that it is compressed when it needs to

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added the PR-Change For updates to an existing feature label Oct 31, 2024
@bmarty bmarty requested a review from a team as a code owner October 31, 2024 10:30
@bmarty bmarty requested review from jmartinesp and removed request for a team October 31, 2024 10:30
Copy link
Contributor

github-actions bot commented Oct 31, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/bUfR6X

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

sonarcloud bot commented Oct 31, 2024

@bmarty bmarty merged commit a9618e8 into develop Nov 4, 2024
24 checks passed
@bmarty bmarty deleted the feature/bma/mediaUpload branch November 4, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Change For updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants