Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor state fixture and preview improvement #3758

Merged
merged 8 commits into from
Oct 31, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 30, 2024

Content

Improve the code for the state composer fixture and for the preview, and add content in the existing preview for the TextComposer.

Motivation and context

Preparatory work for

Screenshots / GIFs

Tests

  • No functional change in this PR, just working around Preview, which is sort of non production code.

Tested devices

  • NA

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty added the PR-Misc For other changes label Oct 30, 2024
@bmarty bmarty requested a review from a team as a code owner October 30, 2024 14:45
@bmarty bmarty requested review from ganfra and removed request for a team October 30, 2024 14:45
Copy link
Contributor

github-actions bot commented Oct 30, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Mem7cN

Copy link

sonarcloud bot commented Oct 30, 2024

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 30, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 30, 2024
@bmarty bmarty merged commit 1dd2ad0 into develop Oct 31, 2024
26 of 28 checks passed
@bmarty bmarty deleted the feature/bma/editorStateFixture branch October 31, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants